From b72fd27ff9759863bba9b21dbb9a18cb58f393ff Mon Sep 17 00:00:00 2001 From: Tim Ramlot <42113979+inteon@users.noreply.github.com> Date: Wed, 13 Mar 2024 15:20:44 +0100 Subject: [PATCH 1/3] explain that cmctl x uninstall is now safe by default Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --- content/docs/reference/cmctl.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/content/docs/reference/cmctl.md b/content/docs/reference/cmctl.md index f130465d0a4..5f400af0e90 100644 --- a/content/docs/reference/cmctl.md +++ b/content/docs/reference/cmctl.md @@ -317,7 +317,10 @@ cmctl x uninstall This command uninstalls any Helm-managed release of cert-manager. -The CRDs will be deleted if you installed cert-manager with the option `--set CRDs=true`. +Starting from cmctl `v2.0.0`, the uninstall command is safe and will not delete the CRDs +by default, even if they were installed with the Helm chart (using the option `--set installCRDs=true`). + +> 👴 Before `v2.0.0`, cmctl would remove the CRDs if they were installed with the Helm chart (similar to Helm's behavior). Most of the features supported by `helm uninstall` are also supported by this command. From 8c893a54a20e03e0dbc819232e05e36da60827bb Mon Sep 17 00:00:00 2001 From: Tim Ramlot <42113979+inteon@users.noreply.github.com> Date: Wed, 13 Mar 2024 15:21:32 +0100 Subject: [PATCH 2/3] remove flag which was removed in v2.0.0 Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --- content/docs/reference/cmctl.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/content/docs/reference/cmctl.md b/content/docs/reference/cmctl.md index 5f400af0e90..a85cebb3990 100644 --- a/content/docs/reference/cmctl.md +++ b/content/docs/reference/cmctl.md @@ -332,8 +332,6 @@ cmctl x uninstall cmctl x uninstall --namespace my-cert-manager cmctl x uninstall --dry-run - -cmctl x uninstall --no-hooks ``` ### Upgrade From 0fcee4e72c3d4ad7ab699b6ee9ebd4ec9fb07fe4 Mon Sep 17 00:00:00 2001 From: Tim Ramlot <42113979+inteon@users.noreply.github.com> Date: Fri, 15 Mar 2024 10:22:46 +0100 Subject: [PATCH 3/3] use better emoji Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com> --- content/docs/reference/cmctl.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/docs/reference/cmctl.md b/content/docs/reference/cmctl.md index a85cebb3990..ab9526a94e2 100644 --- a/content/docs/reference/cmctl.md +++ b/content/docs/reference/cmctl.md @@ -320,7 +320,7 @@ This command uninstalls any Helm-managed release of cert-manager. Starting from cmctl `v2.0.0`, the uninstall command is safe and will not delete the CRDs by default, even if they were installed with the Helm chart (using the option `--set installCRDs=true`). -> 👴 Before `v2.0.0`, cmctl would remove the CRDs if they were installed with the Helm chart (similar to Helm's behavior). +> 🕐 Before `v2.0.0`, cmctl would remove the CRDs if they were installed with the Helm chart (similar to Helm's behavior). Most of the features supported by `helm uninstall` are also supported by this command.