You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
// splitList returns the given csv as a slice. Trims space of each element.
funcsplitList(csvstring) []string {
varlist []string
for_, s:=rangestrings.Split(csv, ",") {
list=append(list, strings.TrimSpace(s))
}
returnlist
}
This split function has no support for escaping commas and as such could be invalid for certain URIs which can legally contain commas. Ideally we should use CSV parsing logic instead, which would allow URIs containing commas to be used.
When parsing URIs we use
splitList
which is defined locally:csi-driver/pkg/requestgen/generator.go
Line 164 in c94e146
csi-driver/pkg/requestgen/generator.go
Lines 223 to 230 in c94e146
This split function has no support for escaping commas and as such could be invalid for certain URIs which can legally contain commas. Ideally we should use CSV parsing logic instead, which would allow URIs containing commas to be used.
For related discussion in a review of a cert-manager feature, see: cert-manager/cert-manager#4502 (comment)
The text was updated successfully, but these errors were encountered: