Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: GT db record for 2017 MC #3696

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tpmccauley
Copy link
Member

One question to resolve is whether or not to have a separate record for the 2016 and 2017 collision GT db when they point to the same file. The other option would be to make a new record for the GT MC db, modify the GT for collision data to include references to 2017, adding a new link.

The XXXX and YYYY in the json file refer to the as-yet-undefined record ids

* Create a record for the 2017 MC GT db
* Additionally create a record for the 2017 collision GT db
* Fix a typo in the 2016 MC GT db record
* Closes cernopendata#3695
Copy link
Contributor

@jmhogan jmhogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMS: Add a record for the 2017 MC condition GT db
2 participants