You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 24, 2024. It is now read-only.
AshishMotanamGurunadham
changed the title
Investigation d3-axis code to fix date format issue.
Investigating d3-axis code to fix date format issue.
Aug 2, 2021
Based on the investigation I have done, when null is passed as tickFormat, d3 determines the format based on tick values consumer provides using this code. Since [this logic] renders (https://github.com/d3/d3-scale/blob/main/src/time.js#L20-L37) irrespective of locale, we are seeing the same format in Carbon for every locale we use, which leads to date format internationalization issue.
To fix this issue, d3 format selection needs to be locale-specific, but the d3 team is not ready to do these changes(which you can see in this comment). So this will leave us with building our own logic based on axis limits provided by consumers to fix the date format issue.
Story
Description
As a developer, I would like to extend my investigation on the date format issue to go through the d3-axis code.
Motivation
So that we can suggest changes to the d3 team to fix the date format issue in terra-graphs
Definition of Done
We'll know we're done when we come up with suggested changes to fix the date format issue.
The text was updated successfully, but these errors were encountered: