Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authorisation for individual Patron GET by ID incorrect? #7

Open
anthonywhitford opened this issue Jun 25, 2024 · 0 comments
Open

Authorisation for individual Patron GET by ID incorrect? #7

anthonywhitford opened this issue Jun 25, 2024 · 0 comments

Comments

@anthonywhitford
Copy link

While investigating LCF Issue 328, relating to profile validation, I was building a PoC for iterating over the Patron entities, by retrieving a list of entities, and then performing a GET for each one. The list function works as expected, however, the individual GET for a specific record fails with a HTTP/403 Forbidden message.

The LCF standard describes authentication and authorisation here: https://github.com/bic-org-uk/bic-lcf/blob/develop/docs/LCF-RESTWebServiceSpecification.md#1-terminal-application-authentication-updated-in-v120

Within this text, the example given is retrieving a single Patron record using a GET request.

GET /lcf/1.0/patrons/{id-value}
Authorization: BASIC {Base64-encoded-terminal-credentials}

where {Base64-encoded-terminal-credentials} is constructed from elements Q00D04.2 and Q00D05.2 (see [4]).

Elements Q00D04.2 and Q00D05.2 defined here are the Terminal ID and Terminal Password.

Checking with Matthew about which credentials should be used, it apparently uses the Patron credentials for this GET request.

This would appear to be incorrect.

ASIDE: I think the ACL for LCF needs improvement in the documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant