feat: interest registration endpoint #246
Conversation
Thanks! And yes, haha, was planning to add unit tests before marking the PR ready 😁 (after I get the e2e tests passing) |
smrz2001
force-pushed
the
feature/ws1-1452-create-interest-endpoint-on-ceramic-api
branch
from
7a3b8d8 to
8123763
Compare
api/src/server.rs
Outdated
| stream_id: Option<String>, | ||
| _context: &C, | ||
| ) -> Result<InterestsSortKeySortValuePostResponse, ApiError> { | ||
| debug!( |
There was a problem hiding this comment.
nit, this debug is redundant as the params are already part of the tracing context and will get logged at debug when the function returns successfully or logged at error in the case of an error.
There was a problem hiding this comment.
Ah nice, ok, taking it out.
| stop_builder.with_controller(&controller).with_max_init(), | ||
| ), | ||
| (None, Some(_)) => { | ||
| return Err(ApiError( |
There was a problem hiding this comment.
It's not a pattern we've been using, but we could add a 400 response and return e.g InterestsSortKeySortValuePostResponse::BadRequest instead of a 500 for things like this. Might be nice to improve the API responses across the board, potentially as a separate ticket. I know changing this would require some refactoring given how this code is shared.
There was a problem hiding this comment.
Yeah, I like that, it's more aligned with how the status codes should be used.
smrz2001
deleted the
feature/ws1-1452-create-interest-endpoint-on-ceramic-api
branch
No description provided.