control/cli: add ip requirement for listener

discovert controller need a specific ip/port. fixes: #87 Signed-off-by: Yin Congmin <[email protected]>
ceph · May 10, 2023 · 3e9effb · 3e9effb
1 parent 8cc5229
commit 3e9effb
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/control/cli.py b/control/cli.py
@@ -11,6 +11,7 @@
 import grpc
 import json
 import logging
+import socket
 from .generated import gateway_pb2_grpc as pb2_grpc
 from .generated import gateway_pb2 as pb2
 from .config import GatewayConfig
@@ -268,10 +269,10 @@ def remove_host(self, args):
 
     @cli.cmd([
         argument("-n", "--subnqn", help="Subsystem NQN", required=True),
-        argument("-g", "--gateway-name", help="Gateway name", default=""),
+        argument("-g", "--gateway-name", help="Gateway name", default=socket.gethostname()),
         argument("-t", "--trtype", help="Transport type", default="TCP"),
         argument("-f", "--adrfam", help="Address family", default="ipv4"),
-        argument("-a", "--traddr", help="NVMe host IP", default=""),
+        argument("-a", "--traddr", help="NVMe host IP", required=True),
         argument("-s", "--trsvcid", help="Port number", required=True),
     ])
     def create_listener(self, args):
@@ -293,10 +294,10 @@ def create_listener(self, args):
 
     @cli.cmd([
         argument("-n", "--subnqn", help="Subsystem NQN", required=True),
-        argument("-g", "--gateway-name", help="Gateway name", default=""),
+        argument("-g", "--gateway-name", help="Gateway name", default=socket.gethostname()),
         argument("-t", "--trtype", help="Transport type", default="TCP"),
         argument("-f", "--adrfam", help="Address family", default="ipv4"),
-        argument("-a", "--traddr", help="NVMe host IP", default=""),
+        argument("-a", "--traddr", help="NVMe host IP", required=True),
         argument("-s", "--trsvcid", help="Port number", required=True),
     ])
     def delete_listener(self, args):