Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Pimp redeem token function #273

Closed
denniswell opened this issue Apr 27, 2020 · 5 comments
Closed

Pimp redeem token function #273

denniswell opened this issue Apr 27, 2020 · 5 comments

Comments

@denniswell
Copy link

image.png
Add max button and show expected investment value

@lucasvo
Copy link
Member

lucasvo commented May 7, 2020

This should not be implemented until we have the new eth widgets in axis (centrifuge/axis#54)

@lucasvo
Copy link
Member

lucasvo commented May 19, 2020

@acolytec3 are you implementing this with the new widget?

@acolytec3
Copy link
Contributor

The messaging isn't in the new widget but the concept of setting a max amount is there with the "set max" button I built as part of the widget. It just looks a little different than what's in that mockup. I should be able to if the amount in DAI is available in the code today or can easily be derived.

@lucasvo
Copy link
Member

lucasvo commented May 19, 2020

Yes, you can ignore the message "You will receive in exchange" and take the design from the widgets we have. The design is outdated in this ticket.

@ilinzweilin how can the max be determined in the code today?

@ilinzweilin
Copy link
Contributor

in the redeem container, you find the values tokenBalance and maxRedeemAmount.
max is the smaller of these two values -> min(tokenBalance, maxRedeemAmount)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants