Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PasswordInput: Show button in size large is off center #1088

Closed
silvalaura opened this issue Jun 22, 2023 · 1 comment · Fixed by #1136
Closed

PasswordInput: Show button in size large is off center #1088

silvalaura opened this issue Jun 22, 2023 · 1 comment · Fixed by #1136
Assignees
@silvalaura
Labels
bug Something isn't working

Comments

@silvalaura
Copy link
Collaborator

silvalaura commented Jun 22, 2023 •
edited
Loading

Describe the bug
The show button in the large PasswordInput is in the wrong place

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://next--upbeat-sinoussi-f675aa.netlify.app/api/password-input/

Screenshots
image

Notes
In addition to fixing the above for large inputs, lets also polish up the show/hide button in the regular size
@silvalaura silvalaura added the bug Something isn't working label Jun 22, 2023
@silvalaura silvalaura mentioned this issue Sep 20, 2023
Merged
4 tasks
@silvalaura silvalaura linked a pull request Sep 20, 2023 that will close this issue
fix(PasswordInput): Update placement of Show/Hide button on Large input size #1136
Merged
4 tasks
@silvalaura silvalaura moved this from To Do to Ready for Review in React Magma Sep 20, 2023
@github-project-automation github-project-automation bot moved this from Ready for Review to Ready for QA in React Magma Oct 5, 2023
@chris-cedrone-cengage
Copy link
Collaborator

Looks good here!

@chris-cedrone-cengage chris-cedrone-cengage moved this from Ready for QA to Done in React Magma Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silvalaura silvalaura

Labels
bug Something isn't working
Projects
React Magma
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(PasswordInput): Update placement of Show/Hide button on Large input size cengage/react-magma
3 participants
@orion-cengage @chris-cedrone-cengage @silvalaura