From ab2e4584398cc8a83ae3c544bc69bbf00ee8ae80 Mon Sep 17 00:00:00 2001 From: 0xarthurxyz <46296830+0xarthurxyz@users.noreply.github.com> Date: Tue, 9 Jan 2024 15:39:02 +0100 Subject: [PATCH 1/2] nit(test): adds context on backwards compatibility tests --- .../odis/identifier-backwards-compatibility.test.ts | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/identity/src/odis/identifier-backwards-compatibility.test.ts b/packages/identity/src/odis/identifier-backwards-compatibility.test.ts index b6b06fb21..01aa90268 100644 --- a/packages/identity/src/odis/identifier-backwards-compatibility.test.ts +++ b/packages/identity/src/odis/identifier-backwards-compatibility.test.ts @@ -30,6 +30,16 @@ const expectedObfuscatedIdentifier = '0xf82c6272fd57d3e5d4e291be16b3ebac5c616084a5e6f3730c73f62efd39c6ae' const expectedPepper = 'Pi4Z1NQnfsdvJ' +/** + * Some context on these tests for future reference: + * + * We're keeping these tests to preserve identifier continuity when doing major upgrades in the + * future. If major upgrades were to break identifier continuity, this could lead to downstream + * problems with SocialConnect users. + * + * This test is flakey because it sends requests to the actual ODIS instance deployed on Alfajores. + * It’s basically an end-to-end test. + */ describe('backwards compatibility of phone number identifiers', () => { beforeAll(() => { fetchMock.reset() From 3d79f48516e75dd6e75d92d7612b8fd821d30ffa Mon Sep 17 00:00:00 2001 From: 0xarthurxyz <46296830+0xarthurxyz@users.noreply.github.com> Date: Tue, 9 Jan 2024 15:40:11 +0100 Subject: [PATCH 2/2] chore(changeset): adds empty changeset --- .changeset/cold-ducks-visit.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changeset/cold-ducks-visit.md diff --git a/.changeset/cold-ducks-visit.md b/.changeset/cold-ducks-visit.md new file mode 100644 index 000000000..a845151cc --- /dev/null +++ b/.changeset/cold-ducks-visit.md @@ -0,0 +1,2 @@ +--- +---