Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issue: insecure cryptography is used #22

Closed
paulmillr opened this issue Dec 15, 2023 · 3 comments · Fixed by #59
Closed

Security issue: insecure cryptography is used #22

paulmillr opened this issue Dec 15, 2023 · 3 comments · Fixed by #59
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@paulmillr
Copy link

https://github.com/celo-org/celo-monorepo/blob/3902e9c3d874cafe406b40aed5dcf38a59963843/packages/sdk/base/package.json#L28

You're using elliptic, which has long been unmaintained, and has a few cases where it produces invalid outputs, which means in blockchain context "users lose money".

It is advised to replace it with audited @noble/curves.

@aaronmgdr aaronmgdr transferred this issue from celo-org/celo-monorepo Dec 18, 2023
@aaronmgdr aaronmgdr added the dependencies Pull requests that update a dependency file label Dec 18, 2023
@nicolasbrugneaux
Copy link
Contributor

nicolasbrugneaux commented Jan 24, 2024

Hello there! The work to replace elliptic (and other unmaintained various cryptographic libraries) has been started in

You're more than welcome to give us advice along the way as you're the maintainer of these audited libraries :)

@arthurgousset
Copy link
Contributor

Thank you also for opening your first issue in this repo @paulmillr. We really appreciate it! :)

@nicolasbrugneaux
Copy link
Contributor

nicolasbrugneaux commented Feb 14, 2024

New WIP PR related to this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants