Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add new metric for the max percentage deviation (Max price cross-sectional deviation) to improve monitoring and alerting #174

Open
erNail opened this issue Jun 27, 2023 · 0 comments · May be fixed by #175

Comments

@erNail
Copy link

erNail commented Jun 27, 2023

Problem / Motivation

While running the Celo Oracles, it can happen that the Oracles fail to send reports due to the max price cross-sectional deviation being too large. In such a case, the logs of the Oracle will show something like Max price cross-sectional deviation too large (0.1} >= 0.01).

With monitoring and alerting for the metric oracle_transaction_success_count, an alert is triggered once the oracle fails to send reports.

In my case, this leads to alerts being triggered because the max price cross-sectional deviation is too large. In my opinion, this case should not trigger an alert, since the oracle works as expected. It's not sending reports due to the deviation being too large. I'd like to avoid being alerted in a case like this.

Proposed Solution

The basic problem is, that currently there is no way to find out (by metrics) if the oracle stopped sending reports because of the deviation being too large. This can be solved by adding a metric for the current max percentage deviation. This way, the alert could be triggered only if the oracle fails to send reports, and the max percentage deviation is below a defined threshold.

I will create a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant