Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ended on an exception #11

Open
jasikpark opened this issue Sep 4, 2020 · 6 comments
Open

Run ended on an exception #11

jasikpark opened this issue Sep 4, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@jasikpark
Copy link
Contributor

https://github.com/jasikpark/jasik-xyz/runs/1073175123?check_suite_focus=true

 /usr/bin/docker run --name b3ac606420a76c0f54fc1963b7689f4fab8f5_562df9 --label 3b3ac6 --workdir /github/workspace --rm -e INPUT_URL -e INPUT_HONORROBOTEXCLUSIONS -e INPUT_IGNOREPATTERNS -e INPUT_RECURSIVELINKS -e HOME -e GITHUB_JOB -e GITHUB_REF -e GITHUB_SHA -e GITHUB_REPOSITORY -e GITHUB_REPOSITORY_OWNER -e GITHUB_RUN_ID -e GITHUB_RUN_NUMBER -e GITHUB_ACTOR -e GITHUB_WORKFLOW -e GITHUB_HEAD_REF -e GITHUB_BASE_REF -e GITHUB_EVENT_NAME -e GITHUB_SERVER_URL -e GITHUB_API_URL -e GITHUB_GRAPHQL_URL -e GITHUB_WORKSPACE -e GITHUB_ACTION -e GITHUB_EVENT_PATH -e RUNNER_OS -e RUNNER_TOOL_CACHE -e RUNNER_TEMP -e RUNNER_WORKSPACE -e ACTIONS_RUNTIME_URL -e ACTIONS_RUNTIME_TOKEN -e ACTIONS_CACHE_URL -e GITHUB_ACTIONS=true -e CI=true -v "/var/run/docker.sock":"/var/run/docker.sock" -v "/home/runner/work/_temp/_github_home":"/github/home" -v "/home/runner/work/_temp/_github_workflow":"/github/workflow" -v "/home/runner/work/jasik-xyz/jasik-xyz":"/github/workspace" 3b3ac6:06420a76c0f54fc1963b7689f4fab8f5  "https://jasik.xyz" "false" "github,google" "true"
/usr/bin/blc -> /usr/lib/node_modules/broken-link-checker/bin/blc
/usr/bin/broken-link-checker -> /usr/lib/node_modules/broken-link-checker/bin/blc
+ [email protected]
added 102 packages from 131 contributors in 4.272s
=== BROKEN LINK CHECKER ===
Running broken link checker on url:  https://jasik.xyz 
Configuration: 
 Honor robot exclusions: false, 
 Exclude urls that match: github,google, 
 Resursive urls: true
/usr/lib/node_modules/broken-link-checker/node_modules/bhttp/lib/bhttp.js:159
  err.response = response;
               ^

TypeError: Cannot assign to read only property 'response' of object '[object Object]'
    at addErrorData (/usr/lib/node_modules/broken-link-checker/node_modules/bhttp/lib/bhttp.js:159:16)
    at ClientRequest.<anonymous> (/usr/lib/node_modules/broken-link-checker/node_modules/bhttp/lib/bhttp.js:567:25)
    at ClientRequest.emit (events.js:198:13)
    at Socket.socketErrorListener (_http_client.js:401:9)
    at Socket.emit (events.js:198:13)
    at emitErrorNT (internal/streams/destroy.js:91:8)
    at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
    at process._tickCallback (internal/process/next_tick.js:63:19)
 Failed 1 broken url(s) found (889 total): 
[✗] https://itunes.apple.com/us/app/clocker-menubar-world-clock/id1056643111?mt=12

I was testing out #7 and ran into this problem. I'm not sure what's wrong, I guess I'll try running it again?

@celinekurpershoek
Copy link
Owner

Are you running from version v1.0.1? I messed up some tags yesterday 😅 I'm now running the action but it can take a while since its testing the readme page with recursive urls.

https://github.com/celinekurpershoek/link-checker/runs/1076144518?check_suite_focus=true#step:2:8

@jasikpark
Copy link
Contributor Author

I've got v1.0.1, yes

@jasikpark
Copy link
Contributor Author

https://github.com/jasikpark/jasik-xyz/blob/master/.github/workflows/broken-link-check.yml

name: Broken Link Check

on:
  schedule:
    - cron: 0 0 1 * * # run monthly
  repository_dispatch: # run manually
    types: [check-link]

jobs:
  broken_link_checker_job:
    runs-on: ubuntu-latest
    name: Check for broken links
    steps:
      - name: Check for broken links
        id: link-report
        uses: celinekurpershoek/[email protected]
        with:
          # Required:
          url: "https://jasik.xyz"
          # optional:
          honorRobotExclusions: false
          ignorePatterns: "github,google"
          recursiveLinks: true # Check all urls on all reachable pages (could take a while)
      - name: Get the result
        run: echo "${{steps.link-report.outputs.result}}"

@celinekurpershoek
Copy link
Owner

going to look into it ;)

@celinekurpershoek
Copy link
Owner

celinekurpershoek commented Sep 5, 2020

It looks like its having trouble with https://jasik.xyz/resume.pdf. When I run it through the blc package itself it gives the error
back:

Error: Expected type "text/html" but got "application/pdf"

Finished! 1442 links found. 1208 excluded. 1 broken.
Elapsed time: 1 minute, 28 seconds```

Gives error:
`$ blc https://jasik.xyz --exclude github --exclude google --follow --ro`

Works with:
`$blc https://jasik.xyz --exclude github --exclude google --exclude *.pdf  --fo
llow --ro`

Applied to plugin:
`bash entrypoint.sh https://jasik.xyz false 'github,google,*.pdf' true`

I have to figure out a way to handle that error better but for now you can use this work around
------
Work around: Add '*.pdf' to ignorePatterns

@jasikpark
Copy link
Contributor Author

Ah so it's erroring because of the mime type ok thanks

@celinekurpershoek celinekurpershoek added the bug Something isn't working label Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants