feat(modshare): implement GetRow #4002
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
requested review from
renaynay,
Wondertan,
walldiss and
cristaloleg
as code owners
vgonkivs
changed the title
Wondertan
reviewed
Dec 12, 2024
Wondertan
reviewed
Dec 12, 2024
Co-authored-by: Hlib Kanunnikov <[email protected]>
vgonkivs
force-pushed
the
implement_get_Row
branch
from
2114715 to
1d0a582
Compare
Wondertan
reviewed
Jan 6, 2025
| @@ -0,0 +1 @@ | |||
| {"x-token": "cdb1b3af1f4f7d841e948ed4a62cae4d4c1ee722"} | |||
| const odsSize = 8 | ||
| eds := edstest.RandEDS(t, odsSize) | ||
| for rowIdx := 0; rowIdx < odsSize*2; rowIdx++ { | ||
| for _, side := range []RowSide{Left, Right} { |
cristaloleg
reviewed
Jan 6, 2025
| @@ -150,6 +150,10 @@ func (sg *Getter) GetSamples(context.Context, *header.ExtendedHeader, []shwap.Sa | |||
| return nil, fmt.Errorf("getter/shrex: GetShare %w", shwap.ErrOperationNotSupported) | |||
| } | |||
|
|
|||
| func (sg *Getter) GetRow(_ context.Context, _ *header.ExtendedHeader, _ int) (shwap.Row, error) { | |||
| return shwap.Row{}, fmt.Errorf("getter/shrex: GetShare %w", shwap.ErrOperationNotSupported) | |||
Wondertan
requested changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3981