Require clang-tidy in CI

[esseivaju]

We've had a clang-tidy job for a while, but it wasn't required to succeed for the CI pipeline to pass. This PR makes it required: if we ever want to require it, the sooner the easier it will be.

I silenced most of the remaining warnings as they were inconsequential, except for a few suspicious cases where I fixed the warning, if they were fine they'd warrant a comment. In particular, fix a potential memory leak in CelerOpticalPhysics if a process is inactive.

[github-actions]

Test summary

 3 844 files   5 936 suites   4m 7s ⏱️
 1 597 tests  1 569 ✅ 28 💤 0 ❌
19 790 runs  19 715 ✅ 75 💤 0 ❌

Results for commit 81d0374.

♻️ This comment has been updated with latest results.

[sethrj]

Thanks @esseivaju ! It's nice to finally have this in place 😄

I think given the number of "false" positives for cppcoreguidelines-rvalue-reference-param-not-moved and cppcoreguidelines-missing-std-forward we should just disable those.

[esseivaju]

I think given the number of "false" positives for cppcoreguidelines-rvalue-reference-param-not-moved and cppcoreguidelines-missing-std-forward we should just disable those.

I enabled AllowPartialMove which makes the check more lenient. There's only a handful left now. Since this is an unusual way of passing parameters (per F.15), I think these checks could be useful, it makes you think twice about it, and future readers know that it was deliberate and not an oversight.