Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cedar 3.0] Remove deprecated features #180

Closed
1 of 2 tasks
khieta opened this issue Jul 14, 2023 · 3 comments
Closed
1 of 2 tasks

[Cedar 3.0] Remove deprecated features #180

khieta opened this issue Jul 14, 2023 · 3 comments
Assignees
Labels
feature-request This issue requets a substantial new feature

Comments

@khieta
Copy link
Contributor

khieta commented Jul 14, 2023

Category

User level API changes

Describe the feature you'd like to request

We have one API and one language feature that are commented as being deprecated. We should consider removing them from the code base in the next major release.

  • The EntityUid::from_str() API has been deprecated since version 1.2 [link]
  • The __expr syntax for specifying Cedar expressions in JSON has been deprecated since version 1.2.

Describe the solution you'd like

Remove the code corresponding to the features above. Removing EntityUid::from_str() should be quick. Removing references to __expr will be more involved. It will also require updating our integration tests, which still use this syntax.

Describe alternatives you've considered

N/A

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@khieta khieta added pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. feature-request This issue requets a substantial new feature labels Jul 14, 2023
@khieta
Copy link
Contributor Author

khieta commented Jul 14, 2023

Made a separate issue for updating the integration tests #181

@cdisselkoen
Copy link
Contributor

Removing EntityUid::from_str() may not be trivial, as the CLI uses it for the --principal, --action, etc arguments. The CLI arguments will probably have to be specified in a different format.

@andrewmwells-amazon andrewmwells-amazon added backlog and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. labels Jul 14, 2023
@aaronjeline aaronjeline self-assigned this Sep 18, 2023
@cdisselkoen
Copy link
Contributor

Closed by #319 and #333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requets a substantial new feature
Projects
None yet
Development

No branches or pull requests

4 participants