Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error message when trying to use in for set membership #177

Closed
2 tasks
cdisselkoen opened this issue Jul 13, 2023 · 0 comments
Closed
2 tasks

Improved error message when trying to use in for set membership #177

cdisselkoen opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels
feature-request This issue requets a substantial new feature

Comments

@cdisselkoen
Copy link
Contributor

Category

Other

Describe the feature you'd like to request

As pointed out by @khieta in this comment on RFC 18. For errors like

context.solution_id in principal.solution_ids

instead of the not-very-helpful error message

Errors: while evaluating policy policy0, encountered the following error: type error: expected (entity of type any_entity_type), got string

we should have something more helpful like this

type error: in expects an entity on the LHS. Use .contains() for set membership

Describe the solution you'd like

As above.

Describe alternatives you've considered

RFC 18 discusses alternatives, but this is something we can do now to help while RFC 18 continues to be discussed and/or implemented.

Additional context

No response

Is this something that you'd be interested in working on?

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change
@cdisselkoen cdisselkoen added pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. feature-request This issue requets a substantial new feature labels Jul 13, 2023
@andrewmwells-amazon andrewmwells-amazon added good-first-issue Good for newcomers. A smaller issue that someone new to the Cedar codebase should be able to tackle backlog and removed pending-triage The cedar maintainers haven't looked at this yet. Automicaly added to all new issues. backlog labels Jul 13, 2023
@khieta khieta self-assigned this Jul 31, 2023
@khieta khieta removed the good-first-issue Good for newcomers. A smaller issue that someone new to the Cedar codebase should be able to tackle label Aug 2, 2023
@khieta khieta closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requets a substantial new feature
Projects
None yet
Development

No branches or pull requests

3 participants