Improve batch error handling #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses IDX-469 Signed-off-by: philhassey <[email protected]>
Addresses IDX-405 Signed-off-by: philhassey <[email protected]>
Addresses IDX-469 Signed-off-by: philhassey <[email protected]>
Addresses IDX-469 Signed-off-by: philhassey <[email protected]>
…essing Addresses IDX-469 Signed-off-by: philhassey <[email protected]>
| ) | ||
| testutil.ErrorIs(t, err, errWant) | ||
| testutil.Equals(t, total, 2) | ||
| }) |
There was a problem hiding this comment.
Maybe add one more test case here that both returns an error and does a context cancel, and verifies that the returned error is both? As I think no tests here are currently exercising the behaviour that the callback error is joined with the context error.
kjamieson-sdm
approved these changes
Dec 3, 2024
…joined Addresses IDX-469 Signed-off-by: philhassey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes two things: