Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignment of file name between examples and schema (both with _ as separator (snake_case)) #188

Open
davidB opened this issue Mar 3, 2024 · 0 comments
Milestone

Comments

@davidB
Copy link
Contributor

davidB commented Mar 3, 2024

Use the same way to name files in examples & schema, both with _ as separator (snake_case format) : {{subject}}_{{predicate}}.json

Questions

  1. Why not add a number (2 digit) into examples to have the possibility to provide several samples {{subject}}_{{predicate}}_{{number}}.json (e.g. pipelinerun_finished_01.json)

Notes

from @afrittoli

From a spec point of view it has a very small impact, but it has ramifications on logic spread across various repos:

  • A CI job in the spec repo itself that checks examples against schemas
  • Scripts in the tools folder in the spec repo that help with managing versions
  • The logic in the cdevents.dev repo that publishes the schemas on the website
    -The logic in the various SDKs (go, java, rust and maybe python) that use the spec as a submodule and generate code from the schemas
@afrittoli afrittoli modified the milestones: v0.4, v0.5 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants