Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content.outcome field is not declared as enums #124

Open
e-backmark-ericsson opened this issue Apr 12, 2023 · 1 comment
Open

content.outcome field is not declared as enums #124

e-backmark-ericsson opened this issue Apr 12, 2023 · 1 comment
Labels
roadmap Items on the roadmap
Milestone

Comments

@e-backmark-ericsson
Copy link
Contributor

The documentation for pipelineRun.finished and taskRun.finished declares that the outcome shall be an enum with a limited set of values. The schemas declare these fields as free text strings though.

We need to align this, and at the same time I believe we should decide on and document how we should format these kinds of enum values. I prefer to see them as "constants" and use the well established formatting of UPPERCASE values for them, but I'm open for other decisions as well, as long as we align our enum values' formats all-over the protocol

@e-backmark-ericsson e-backmark-ericsson added the roadmap Items on the roadmap label Jun 5, 2023
@e-backmark-ericsson e-backmark-ericsson added this to the v0.4 milestone Jun 5, 2023
@e-backmark-ericsson
Copy link
Contributor Author

Partly covered in #158 and fully covered in #179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
roadmap Items on the roadmap
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants