Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concat call needs stdlib 4.6.0 #57

Open
becomingwisest opened this issue Jun 25, 2020 · 6 comments
Open

concat call needs stdlib 4.6.0 #57

becomingwisest opened this issue Jun 25, 2020 · 6 comments

Comments

@becomingwisest
Copy link
Contributor

https://github.com/ccin2p3/puppet-cpan/blob/v2.0.0/manifests/params.pp#L50 uses concat with 3 arrays, but support for more then two arrays came in 2.6.0 per https://github.com/puppetlabs/puppetlabs-stdlib/blob/4.6.x/CHANGELOG.md

Otherwise you get errors like Error 400 on SERVER: concat(): Wrong number of arguments given (3 for 2) at

Could we get a 2.0.x branch for a pull request to fix this and other issues?
becomingwisest added a commit to becomingwisest/puppet-cpan that referenced this issue Jun 25, 2020
@becomingwisest
params.pp uses concat with 3 arrays, it needs stdlib 2.6.0 [ccin2p3#57]
03425d3 
https://github.com/puppetlabs/puppetlabs-stdlib/blob/4.6.x/CHANGELOG.md
updated concat to support multiple arrays.

If we use less then that, we get
`Error 400 on SERVER: concat(): Wrong number of arguments given (3 for 2) at`
for `cpan/manifests/params.pp:50`
@becomingwisest
Copy link
Contributor Author

https://github.com/becomingwisest/puppet-cpan/tree/stdlib-concat-params-fix has the fix.

@faxm0dem
Copy link
Member

Thanks, just open the PR against master

@becomingwisest
Copy link
Contributor Author

@faxm0dem #58 has finally been opened.

@becomingwisest becomingwisest changed the title concat call needs stdlib 2.6.0 concat call needs stdlib 4.6.0 Jul 24, 2020
@becomingwisest
Copy link
Contributor Author

Meh, reading it again, its 4.6.0. If you'd like I can work on some test(s) to double check my expectations.

becomingwisest added a commit to becomingwisest/puppet-cpan that referenced this issue Jul 27, 2020
@becomingwisest
puppetlabs-stdlib concat multiple arrays is 4.6.0
1b5371c 
https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/CHANGELOG.md#features-11

ccin2p3#57
faxm0dem pushed a commit that referenced this issue Jul 28, 2020
@becomingwisest @faxm0dem
puppetlabs-stdlib concat multiple arrays is 4.6.0
3629045 
https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/CHANGELOG.md#features-11

#57
@theevilapplepie
Copy link
Contributor

@faxm0dem / @becomingwisest -- Are we good to close or is this still an open issue?

@faxm0dem
Copy link
Member

I think we're good, @becomingwisest ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@faxm0dem @becomingwisest @theevilapplepie