Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Notes on analogous WebGL proposal" doesn't quite work #4

Open
domenic opened this issue Jul 17, 2024 · 1 comment
Open

"Notes on analogous WebGL proposal" doesn't quite work #4

domenic opened this issue Jul 17, 2024 · 1 comment

Comments

@domenic
Copy link

domenic commented Jul 17, 2024

In particular

  gl.drawingBufferToneMapping = { mode:"extended" };

implies setting the value of an attribute to a dictionary. But Web IDL attributes cannot return dictionaries, so this would break.

You'd need either something like

gl.setDrawingBufferToneMapping({ mode: "extended" });

// now gl.getDrawinBufferToneMapping() can return a fresh dictionary each time

or

gl.drawingBufferToneMappingMode = "extended";

// and future extensions will also need to be flattened
@ccameron-chromium
Copy link
Owner

Thanks for the input! I'll discuss with the WebGL people about resolving this. The WebGPU API is much nicer in terms of setting these properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants