Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit highlights as per updates to style guide #180

Open
1 task done
Gawidev opened this issue Nov 9, 2024 · 0 comments · May be fixed by #181
Open
1 task done

Revisit highlights as per updates to style guide #180

Gawidev opened this issue Nov 9, 2024 · 0 comments · May be fixed by #181
Labels
enhancement New feature or request

Comments

@Gawidev
Copy link
Contributor

Gawidev commented Nov 9, 2024

Is there an existing issue outlining your improvement?

  • I have searched the existing issues and my improvement has not been raised yet.

What would you like to see added and/or changed?

Ive taken a look through the code editor section of the current style guide, and noticed a few differences with the current Jetbrains Rider themes. When inquiring in the discord, I was informed this was not intended, so I will document them here.

Syntax Current Value Style Guide
Code Comments Overlay 0 Overlay 2
Active Line Number Overlay 1 Lavender
Search BG Non-palette color Teal*
Active Search BG Base Red*

*I was told these should be at 10% opacity


On another note, I've noticed a particular impracticality due to the chosen "Unused Code" color being Overlay 2 (same as the current "Braces, Delimiters" color). This means that it isn't currently possible to visually confirm that a lone pair of braces is "redundant code" or not. Personally, I would think changing the color to Overlay 0 would accentuate the difference and more appropriately emphasize the represented purpose of the syntax, and would be curious to hear any thoughts on the matter.

Furthermore, it seems that the Subtext 1 & 2 colors are not used anywhere in the Editor Color Scheme. This may be more opinionated, but I would like to suggest potentially using them to differentiate between local variables, fields, properties, and events. Usually, naming conventions tend to serve this purpose, but the subtle differences in text color might be a nice intuition-guiding touch, while still being similar enough to represent the same group of Instance Field/Identifier syntax elements.

Once again, just some thoughts, thanks regardless for the lovely theme implementation. 🐈‍⬛

@Gawidev Gawidev added the enhancement New feature or request label Nov 9, 2024
@Gawidev Gawidev linked a pull request Nov 10, 2024 that will close this issue
@sgoudham sgoudham changed the title Updating to match Style Guide Revisit highlights as per updates to style guide Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant