errorf improvements

[ccoVeille]

I'm still surprised by the ability of people to create code

• fmt.Errorf("%s", "whatever")

• fmt.Errorf("%w", err)

Some are using fmt.Errorf("%w", ErrSentinel)

These could somehow be addressed with code close to sprint1 with fmt.Errorf, but I think it should be in errorf

Originally posted by @ccoVeille in mgechev/revive#1142 (comment)

[catenacyber]

Indeed, fmt.Errorf("%s", "whatever") is not tested and seems not handled.
Will you work on this ?

[catenacyber]

But not every linter agrees it seems : go-critic/go-critic#1381

[ccoVeille]

The fact gocritic doesn't support it, allow you to add it in your own lib 😅

[ccoVeille]

We could also add

fmt.Errorf("%s", err)
https://github.com/search?q=language%3Ago++%22fmt.Errorf%28%5C%22%25s%5C%22%2C+err%22&type=code

But this one might be already reported by another linter

This one is insane
fmt.Errorf("%s", err.Error())
https://github.com/search?q=language%3Ago++%22fmt.Errorf%28%5C%22%25s%5C%22%2C+err.Error%22&type=code

fmt.Sprintf("%s", err.Error())
https://github.com/search?q=language%3Ago++%22fmt.Sprintf%28%5C%22%25s%5C%22%2C+err.Error%22&type=code

[ccoVeille]

Will you work on this ?

Not yet, it was more a message in the bottle, to add it later.

Anyone can work on it