-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent redirects when not logged into moodle #17
Comments
thanks @kaseyhackspace Can you give an example use case for why you'd want that? If you added a redirect using say apache or nginx you typically don't care about the user at all its just a blanket redirect. |
Hi @brendanheywood , thanks for responding. We're mass redirecting a lot of |
Just had another client ask for something similar to this but the exact opposite. I'm gonna propose we add a flag syntax which we can reuse for other features, vaguely inspired by the apache syntax:
The alternative is we ditch specifying redirects as a text area and move to editing each one as a record with a form and these could be tick boxes. |
Hi @brendanheywood , I vote for the flag syntax on the text area. Reason is due to the number of redirects we have to make, I made a script that generates the redirect rules that I put in the text area. If it was a per record approach, might be harder to maintain hundreds of links by batch? |
Yeah textarea certainly makes that easier. We could expose it with a cli / web service to add and remove them pragmatically but its just more work |
Yeah the KISS principle applies to this one. |
It would be good if the plugin prevents redirects if the user is not logged into moodle. The current behavior is that custom redirects are still applied even if you access the "redirect from" link in incognito where a user is not logged in.
The text was updated successfully, but these errors were encountered: