Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#326] change field referer to text #327

Merged
merged 2 commits into from
Sep 4, 2023
Merged

[#326] change field referer to text #327

merged 2 commits into from
Sep 4, 2023

Conversation

jwalits
Copy link
Contributor

@jwalits jwalits commented Aug 29, 2023

Fixes #326

keevan
keevan approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@keevan keevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I know it's unrelated, but are you able to take a look at the failing CI as well? It seems like the duplicate code check is complaining, and it might be a quick one to resolve.

@keevan keevan enabled auto-merge (rebase) September 4, 2023 05:17
@jwalits
Copy link
Contributor Author

jwalits commented Sep 4, 2023

Looks good, I know it's unrelated, but are you able to take a look at the failing CI as well? It seems like the duplicate code check is complaining, and it might be a quick one to resolve.

Sure, I'll try and have a look at those today......thanks for reviewing @keevan

@keevan keevan merged commit c4b7746 into MOODLE_35_STABLE Sep 4, 2023
24 checks passed
@jwalits jwalits deleted the issue326 branch September 4, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keevan keevan keevan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referrer URL is too long for the field
2 participants
@jwalits @keevan