Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document forceloginforprofileimage and how this affects the avatar #6

Open
brendanheywood opened this issue Sep 15, 2022 · 1 comment
Open

Document forceloginforprofileimage and how this affects the avatar #6

brendanheywood opened this issue Sep 15, 2022 · 1 comment

Comments

@brendanheywood
Copy link
Contributor

No description provided.

@Peterburnett
Copy link

https://tracker.moodle.org/browse/MDL-48245

Currently there is an issue where forcelogin is overriding the forceloginforprofileimage control, and so there is no way to have only the profile images be a public resource. HQ have dropped this issue, which is weird to me, but I think with this tool, instead we should just munge provide a proxy specifically only for profile images. That way we dont open up unintended holes, and control the egress of non-logged in leaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brendanheywood @Peterburnett