Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add more logging to shutdown and signal handler #870

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: add more logging to shutdown and signal handler #870

merged 1 commit into from
Feb 27, 2024

Conversation

keevan
Copy link
Contributor

@keevan keevan commented Feb 27, 2024

Resolves #869

matthewhilton
matthewhilton approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@matthewhilton matthewhilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good no issues - just 1 CI error from a line being too long.

Not necessary but it would be good to test this somehow ?

@keevan keevan force-pushed the 869-add-additional-logging-for-sudden-shutdowns branch from 7d2e603 to 8ef7fa9 Compare February 27, 2024 02:21
@keevan keevan merged commit a75df4a into MOODLE_401_STABLE Feb 27, 2024
15 checks passed
@keevan keevan deleted the 869-add-additional-logging-for-sudden-shutdowns branch February 27, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhilton matthewhilton matthewhilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataflows stopping abruptly, unsure why, needs more logging
2 participants
@keevan @matthewhilton