Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.4+: Callback before_footer in tool_abconfig component should be migrated to new hook callback for core\hook\output\before_footer_html_generation #67

Open
aspark21 opened this issue Jul 14, 2024 · 1 comment

Comments

@aspark21
Copy link

Similar to #65 but different callback that needs migrating

core.core_renderer_test/test_before_footer_html_generation_hooked
core\core_renderer_test::test_before_footer_html_generation_hooked
Unexpected debugging() call detected.
Debugging: Callback before_footer in tool_abconfig component should be migrated to new hook callback for core\hook\output\before_footer_html_generation
* line 7475 of /lib/moodlelib.php: call to debugging()
* line 7589 of /lib/moodlelib.php: call to {closure}()
* line 71 of /lib/classes/hook/output/before_footer_html_generation.php: call to get_plugins_with_function()
* line 1503 of /lib/outputrenderers.php: call to core\hook\output\before_footer_html_generation->process_legacy_callbacks()
* line 101 of /lib/tests/core_renderer_test.php: call to core_renderer->footer()
* line 1617 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to core\core_renderer_test->test_before_footer_html_generation_hooked()
* line 1223 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
* line 72 of /lib/phpunit/classes/advanced_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
* line 729 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to advanced_testcase->runBare()
* line 973 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
* line 685 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
* line 685 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 685 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 651 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
* line 146 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->run()
* line 99 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
* line 107 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()
* line 122 of /vendor/bin/phpunit: call to include()


/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
@leonstr
Copy link
Contributor

leonstr commented Nov 12, 2024

As far as I can see #65 (056dd03) also migrated the before_footer_html_generation callback.

If I run the PHPUnit tests with Moodle 4.4.4+ (Build: 20241101), tool_abconfig 2024060400 (branch MOODLE_38_STABLE, commit b033b5c) with PHP 8.1.19 all tests pass. There are no Callback ... should be migrated messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants