Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix namespacing issues in 4.2+ #58

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

matthewhilton
Copy link

@matthewhilton matthewhilton commented Aug 9, 2024

@matthewhilton matthewhilton force-pushed the fix-class-namespace-tests branch from a4da110 to 0aa8ef7 Compare August 9, 2024 01:17
@matthewhilton matthewhilton marked this pull request as draft August 9, 2024 02:09
@matthewhilton matthewhilton force-pushed the fix-class-namespace-tests branch from bd04ae2 to 54913db Compare August 19, 2024 02:06
@matthewhilton matthewhilton force-pushed the fix-class-namespace-tests branch 5 times, most recently from 7d448ea to b8d0d18 Compare August 19, 2024 02:52
@matthewhilton matthewhilton force-pushed the fix-class-namespace-tests branch 2 times, most recently from 09000ac to fc749dc Compare August 19, 2024 03:16
@matthewhilton matthewhilton force-pushed the fix-class-namespace-tests branch 3 times, most recently from 7cf43b5 to c27efc2 Compare August 19, 2024 22:21
@matthewhilton matthewhilton self-assigned this Aug 19, 2024
@matthewhilton matthewhilton marked this pull request as ready for review August 19, 2024 22:22
@matthewhilton
Copy link
Author

The upstream CI issue has been resolved, so now the CI is running properly. Unfortunately there are lots of pre-existing code standards errors that are out of scope to fix here.

However, the failing tests in 4.4 that prompted this change have been resolved:

4) core_external\external_api_test::test_all_external_info with data set "mod_hvp_log_drain" (stdClass Object (...))
Error: Class "external_api" not found
5) core_external\external_api_test::test_all_external_info with data set "mod_hvp_submit_mobile_finished" (stdClass Object (...))
Error: Class "external_api" not found

Confirmed resolved via CI unit tests + also I have tested manually current main + 4.1 branch and it maintains compatibility with both.

@matthewhilton matthewhilton merged commit 7afcc40 into stable-catalyst-400 Aug 19, 2024
7 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant