Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can update manager email address but value not saved or used #73

Open
peverist opened this issue Feb 28, 2022 · 1 comment
Open

Comments

@peverist
Copy link

Moodle 3.10.6
mssql 11.00.7493
php 7.2.26
mod-facetoface 3.9.1 (2020080400)

If manager approval is turned on in F2F then the manager email in the user (student/employee) profile (shortname managersemail) is correctly displayed for confirmation.
The manager email field can be updated by the user but it looks as if the value is ignored and the manager confirmation email goes to the (incorrect) original value in the user profile regardless. The manager value in the user profile is often wrong or may be away etc so allowing the user to nominate an alternate address is required (even if only for this request and doesn't update the profile) .

Code screenshot provided by our hosting company indicates the capability for the user to update the address may have been removed by Stacy Walker? (although the user still has the ability to enter an alternate value)
F2F Code screenshot

Can you please confirm the current function of the manager approval dialogue for whether the user should be able to update the field and the save and email send functions

thanks, Phil

@danmarsden
Copy link
Member

Hi Phil,

thanks for the report, if your hosting company has development capabilities, feel free to get them to submit a PR to improve this - unfortunately we don't have a lot of volunteer time to work on F2F.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants