Fix #350: Do not setcookie during unit tests

catalyst · Nov 25, 2024 · 68959e3 · 68959e3
1 parent 386a623
commit 68959e3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/classes/local/outagelib.php b/classes/local/outagelib.php
@@ -311,8 +311,9 @@ public static function create_climaintenancephp_code($starttime, $stoptime, $all
     }
     // Put access key as a cookie if given. This stops the need to put it as a url param on every request.
     $urlaccesskey = optional_param('accesskey', null, PARAM_TEXT);
+    $isphpunit = defined('PHPUNIT_TEST');
 
-    if (!empty($urlaccesskey)) {
+    if (!empty($urlaccesskey) && !$isphpunit) {
         setcookie('auth_outage_accesskey', $urlaccesskey, time() + 86400, '/', '', {{COOKIESECURE}}, {{COOKIEHTTPONLY}});
     }
 
@@ -322,7 +323,6 @@ public static function create_climaintenancephp_code($starttime, $stoptime, $all
     $ipblocked = !remoteip_in_list('{{ALLOWEDIPS}}');
     $accesskeyblocked = $useraccesskey != '{{ACCESSKEY}}';
     $allowed = ({{USEACCESSKEY}} && !$accesskeyblocked) || ({{USEALLOWEDIPS}} && !$ipblocked);
-    $isphpunit = defined('PHPUNIT_TEST');
 
     if (!$allowed) {
         if (!$isphpunit) {