Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moodle install issues being swallowed / collapsed out of view #78

Open
2 tasks
keevan opened this issue Aug 23, 2022 · 0 comments
Open
2 tasks

Moodle install issues being swallowed / collapsed out of view #78

keevan opened this issue Aug 23, 2022 · 0 comments

Comments

@keevan
Copy link
Contributor

keevan commented Aug 23, 2022

https://github.com/catalyst/moodle-tool_fix_delete_modules/runs/7964502462

vs

https://github.com/catalyst/moodle-tool_fix_delete_modules/runs/7964502462?check_suite_focus=true#step:4:772
(referencing the section with issues)

Since errors were appearing (exit codes) later on, it wasn't obvious as to why the workflow was failing. Expanding the 'Moodle install output' block revealed underlying issues.

Rough brain dump, but it would be better if:

  • All CI steps should emit an exit code on success or failure
  • When they fail, their output should not be collapsed so it's more obvious to the end user what the issue is. This handling should be generic if possible (success = collapsed output, fail = show output)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant