Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing contracts: update the naming convention from deploy to transaction #1460

Closed
wants to merge 2 commits into from
Closed

Installing contracts: update the naming convention from deploy to transaction #1460

wants to merge 2 commits into from

Conversation

sczembor
Copy link
Contributor

@sczembor sczembor commented Jun 13, 2024 •
edited
Loading

What does this PR fix/introduce?

  • update naming convention from Deploy to Transaction, sender to signer
  • update the casper-client commands

Checklist

(Delete any that aren't relevant)

  • Docs are successfully building - yarn install && yarn run build.
  • For new internal links I used relative file paths (with .md extension) - e.g. ../../faq/faq-general.md - instead of introducing absolute file path, or relative/absolute URL.
  • All external links have been verified with yarn run check:externals.
  • My changes follow the Casper docs style guidelines.

Reviewers

@ACStoneCL

@github-actions GitHub Actions
Copy link

🚀 Deployed on https://666adcedc5526d105cc5c2c9--sensational-creponne-f0e56d.netlify.app

ipopescu
ipopescu reviewed Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the other PR, the changes look good. Please confirm that you were able to test them before approval. This step is usually included in the PR checklist.

@sczembor sczembor changed the title update the naming convention from deploy to transaction Installing contracts: update the naming convention from deploy to transaction Jun 20, 2024
@melpadden melpadden closed this Sep 10, 2024
@melpadden melpadden deleted the local_network_testing_put_deploy-rename branch September 10, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipopescu ipopescu ipopescu left review comments

@ACStone-MTS ACStone-MTS Awaiting requested review from ACStone-MTS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sczembor @ipopescu @melpadden