Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. Python SDK page updated. #1431

Merged
merged 18 commits into from
Apr 18, 2024
Merged

1. Python SDK page updated. #1431

merged 18 commits into from
Apr 18, 2024

Conversation

asladeofgreen
Copy link
Contributor

@asladeofgreen asladeofgreen commented Apr 16, 2024 •
edited
Loading

What does this PR fix/introduce?

Obsolete Python SDK page content.

Closes #1430

Additional context

Simplified page by pointing directly to dedicated How To pages within SDK repo itself.

Checklist

(Delete any that aren't relevant)

  • Docs are successfully building - yarn install && yarn run build.
  • All external links have been verified with yarn run check:externals.
  • My changes follow the Casper docs style guidelines.

Reviewers

@ipopescu

@asladeofgreen asladeofgreen added the enhancement New feature or request label Apr 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 16, 2024 •
edited
Loading

🚀 Deployed on https://6620edf4b489d6d517523081--sensational-creponne-f0e56d.netlify.app

ipopescu
ipopescu approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@ipopescu ipopescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a few minor nits. Removing the question marks seems cleaner.

source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
source/docs/casper/developers/dapps/sdk/python-sdk.md Outdated Show resolved Hide resolved
@ipopescu
Copy link
Collaborator

The build will be fixed with this PR:
#1429

asladeofgreen and others added 17 commits April 18, 2024 11:48
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
9e9477b 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
2f7757d 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
83505bd 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
f5fbe3c 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
95cbb6a 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
5bab2ff 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
e91632b 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
20f7e17 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
e1a58f7 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
c8f296f 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
4f30b5a 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
f1b5c53 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
7ea2e78 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
80ccd30 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
c040b5e 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
a45f24b 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen @ipopescu
Update source/docs/casper/developers/dapps/sdk/python-sdk.md
f381943 
Co-authored-by: Iulia Popescu <[email protected]>
@asladeofgreen
Copy link
Contributor Author

@ipopescu Incorporated your nits !

@ipopescu
Copy link
Collaborator

Great, then I will merge it.

@ipopescu ipopescu merged commit 2db1a14 into dev Apr 18, 2024
11 checks passed
@ipopescu ipopescu deleted the issues/1430 branch April 18, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipopescu ipopescu ipopescu approved these changes

@ACStone-MTS ACStone-MTS Awaiting requested review from ACStone-MTS

Assignees

@ipopescu ipopescu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Obsolete Python SDK content
2 participants
@asladeofgreen @ipopescu