Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host and display the JSON-RPC schema in an easier to read format - Testnet #314

Closed
devendran-m opened this issue Mar 31, 2022 · 6 comments
Closed
Assignees

Comments

@devendran-m
Copy link
Contributor

devendran-m commented Mar 31, 2022

Request:

We can currently query the node: http://65.21.235.219:8888/rpc-schema.
Or use the Casper client subcommand list-rpcs.
MAKE created this URL for the previous version (1.0.0): http://casper-rpc-docs.s3-website-us-east-1.amazonaws.com/.
Please help create a similar link for the Testnet

Component: JSON-RPC
Assignee: SRE team
cc: @sacherjj @bradjohnl

@devendran-m devendran-m assigned bradjohnl and unassigned bradjohnl Mar 31, 2022
@ipopescu
Copy link
Collaborator

@devendran-m can you please discuss this with the SRE team?

@RitaMAllenCA
Copy link

@sacherjj @bradjohnl Should this be in the SRE repo? Doesn't look like a docs issue

@sacherjj
Copy link
Contributor

sacherjj commented Nov 8, 2022

Rendering would only need to be done as part of a node release and eventually rpc sidecar release. But it should live on the docs site.

@bradjohnl
Copy link
Contributor

bradjohnl commented Apr 27, 2023

After testing and analysis, I have concluded, also thanks to @andrzej-casper help, that it is currently not possible to render the OpenRPC API definition inside the JSONRPC documentation that gets produced by calling the casper-client list-rpcs function, using the OpenRPC provided libraries and tooling.

The main reason for that is due to a combinations of 2 things:

I can provide more information with specific examples if needed, but for the sake of clarity, I am omitting them in this comment.

How do we move forward heavily depends on how much time and effort we want to dedicate on making this work.

  1. Dive deeper into the libraries involved in the bug above, and submit a PR to fix the bug.
  2. Create our own generator that loops through the JSON spec and generates the pretty documentation as html.
  3. Try to implement proper referencing in the generated documentation so that circular references are eliminated or replaced with other constructs.

It's currently very hard to estimate the effort necessary for each course of action. TBH I think the option N.1 is probably the quickest, followed by a close battle between 2. and 3.
As the documentation is very long and complex, it might be an equally sizable effort to untangle it compared to creating our own pretty renderer.

@sacherjj @devendran-m @RitaMAllenCA

@RitaMAllenCA
Copy link

Moving this to the 2.0 timeframe for further consideration. We will organically be making updates to the RPC client and perhaps as part of that work we can reconsider this.

@ACStone-MTS
Copy link
Contributor

Closing this ticket and #313 based on the discussions here in and the fact that we host the JSON-RPC API in its entirety on the docs site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants