Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading solely from file system is very hard #1380

Open
JakeWharton opened this issue Jul 9, 2024 · 1 comment
Open

Loading solely from file system is very hard #1380

JakeWharton opened this issue Jul 9, 2024 · 1 comment
Labels

Comments

@JakeWharton
Copy link
Collaborator

I want to load from the file system in tests. This is very had to do. Everything about the current design of loader assumes remote loading.

I'm not sure if the current design can even be adapted to accommodate this case, but perhaps a new foundational design could allow a more modular composition of load sources.

@swankjesse
Copy link
Collaborator

Agreed about a new foundational design. ZiplineLoader has some ideas that haven’t worked out very well in practice, and I’d like to consider building a replacement.

I think our design is too imperative. I’d like to change it to make a loading decision, then execute it, as I describe here:
https://publicobject.com/2024/03/10/deciders-decisions-and-executors/

There’s a lot of moving parts to the decision and ideally we’re extremely conservative about how much I/O we do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants