Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Improve Check-version #529

Open
fmoura opened this issue Jul 19, 2024 · 0 comments
Open

[CLI] Improve Check-version #529

fmoura opened this issue Jul 19, 2024 · 0 comments
Assignees
@fmoura
Labels
#feat:rollups-cli Feature: cartesi-rollups-cli
Milestone
2.0.0

Comments

@fmoura
Copy link
Contributor

fmoura commented Jul 19, 2024

📚 Context

Check Version is relying on a hardcoded schema version, an it is prone to error

✔️ Solution

Make the Schema Manager gets the expected version from the "migrations" files
@fmoura fmoura added the #feat:rollups-cli Feature: cartesi-rollups-cli label Jul 19, 2024
@fmoura fmoura self-assigned this Jul 19, 2024
@fmoura fmoura added this to Node Unit Jul 19, 2024
@fmoura fmoura moved this to 📋 Backlog in Node Unit Jul 19, 2024
@marcelstanley marcelstanley added this to the TBD milestone Jul 26, 2024
@marcelstanley marcelstanley modified the milestones: TBD, 2.x Aug 2, 2024
@marcelstanley marcelstanley modified the milestones: 2.x, 2.0.0 Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmoura fmoura

Labels
#feat:rollups-cli Feature: cartesi-rollups-cli
Projects
Node Unit
Status: 📋 Backlog
Milestone
2.0.0
Development

When branches are created from issues, their pull requests are automatically linked.

feature/check-version-from-source cartesi/rollups-node
2 participants
@fmoura @marcelstanley