Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EVM Reader to read claim status #494

Open
3 tasks
GMKrieger opened this issue Jun 27, 2024 · 1 comment
Open
3 tasks

Update EVM Reader to read claim status #494

GMKrieger opened this issue Jun 27, 2024 · 1 comment
Assignees
Labels
#feat:evm-reader Feature: evm reader
Milestone

Comments

@GMKrieger
Copy link
Contributor

📚 Context

The contract now emits an event that signals that a claim has been accepted, and the Node needs to catch this event and update the data on the repository.

The input reader currently is the service that reads the chain information block by block, and so, it needs to be updated to correctly identify this claim acceptance events and update the repository.

✔️ Solution

The input reader already is responsible for reading the chain, and gets every new block it produces. Now, it will check not only for new inputs, but for claim accepted events. Whenever a block contains this event, the reader needs to update the claim status on the database.

To match its new functionality, the input reader should be renamed to evm reader.

📈 Subtasks

  • Created new repository method
  • Update reader to detect claim accepted events
  • Update algorithm to correctly update when a new claim event arrives
@GMKrieger GMKrieger moved this to 📋 Backlog in Node Unit Jun 27, 2024
@GMKrieger GMKrieger added the #feat:evm-reader Feature: evm reader label Jun 27, 2024
@GMKrieger GMKrieger added this to the 2.0.0 milestone Jun 27, 2024
@fmoura fmoura assigned fmoura and GMKrieger and unassigned GMKrieger and fmoura Jul 15, 2024
@fmoura
Copy link
Contributor

fmoura commented Jul 15, 2024

Right now the the Claim model at 2.0 Spec, dos not have a way of narrowing down on which block a claim was published to serve as a starting point to check for ClaimAcceptance event. Maybe it is just an optmization, but ould be nice to have something so the component do not keep re-checking the same blocks it already checked.

@marcelstanley marcelstanley changed the title Update input reader to read claim status Update EVM Reader to read claim status Aug 2, 2024
@marcelstanley marcelstanley assigned fmoura and unassigned GMKrieger Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#feat:evm-reader Feature: evm reader
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants