Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination #6

Open
reinhardt1053 opened this issue Oct 7, 2019 · 3 comments
Open

Pagination #6

reinhardt1053 opened this issue Oct 7, 2019 · 3 comments
Assignees
@banaslee
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@reinhardt1053
Copy link

Any plan to add pagination to the post list?
@carson-katri carson-katri added the good first issue Good for newcomers label Oct 14, 2019
@carson-katri
Copy link
Owner

I haven't gotten around to something like that, as I was mostly focusing on #5. However, feel free to try implementing it. It sounds like it'd be a good first issue.

@carson-katri carson-katri added the enhancement New feature or request label Oct 14, 2019
@banaslee
Copy link
Contributor

banaslee commented Jun 8, 2020

I’m giving it a shot but oh my, Reddit API is complicated for pagination.

@banaslee
Copy link
Contributor

banaslee commented Jun 9, 2020

Quick update on pagination:
I was able to figure out Reddit API and got to do pagination with buttons on macOS.

Doing infinite scrolling is a different beast and realised now my approach won't work with infinite scrolling as far as I know.

Feedback is very welcome as I feel a bit blocked at the moment. Branch at https://github.com/banaslee/reddit-swiftui/tree/pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@banaslee banaslee

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@reinhardt1053 @banaslee @carson-katri