Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SFSymbols on macOS Big Sur #26

Open
01GOD opened this issue Oct 20, 2020 · 2 comments
Open

Use SFSymbols on macOS Big Sur #26

01GOD opened this issue Oct 20, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@01GOD
Copy link

01GOD commented Oct 20, 2020

Hi

So that extension on NSImage on macOS makes a blank image and has a placeholder input string to maybe do something with in the future or...?

Thanks in advance.
@carson-katri
Copy link
Owner

As per the Readme:

Because macOS doesn't support SF Symbols, I have created the following extension to make sure shared code works. I would like to replace this with custom icons for macOS that it loads from XCAssets eventually

Since macOS BigSur now supports SF Symbols, we should probably just use an @available check.

@carson-katri carson-katri changed the title So that extension on NSImage on macOS makes a blank image and has a placeholder input string to maybe do something with in the future or...? Use SFSymbols on macOS Big Sur Oct 28, 2020
@carson-katri carson-katri added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Oct 28, 2020
@Dishant10
Copy link

Hey,
I'm interested in solving this issue as I have experience with both SwiftUI and SFSymbols. I think I can handle this. Could you please share some more information about the issue. ?
Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@01GOD @carson-katri @Dishant10