Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer review #1

Open
carolinetang77 opened this issue Mar 21, 2023 · 3 comments
Open

Peer review #1

carolinetang77 opened this issue Mar 21, 2023 · 3 comments

Comments

@carolinetang77
Copy link
Owner

No description provided.

@shaunhutch
Copy link

Great looking app! I loved the tooltips on the bar chat to include the number of each outcome for the Queens! In addition, I thought that the explanation of how the "dusted or busted" score is calculated so that the user does not have to refer elsewhere to find that information.
Minor thing, the headers for the data table are inconsistent between capitalization of the whole word or all lowercase. I believe that is because those are the column headers in the original data frame. Perhaps you could update those to be title case so it looks cleaner?
I think the layout could have a minor improvement by having the graph and data table on top of each other. This way there isn't so much white space at the bottom of the dashboard, and you aren't limited to horizontal space.
These are super minor changes that I think could help your app. But overall, the app looks great and runs well!

@dhruvinishar
Copy link

dhruvinishar commented Mar 22, 2023

  • Excellent looking app! I love the neat layout of the app where you can see the information in one screen.
  • Love how the tooltip is also coloured with the bars - Although a legend telling what the colour shows would be more helpful instead of reading the tooltip.
  • The titles in the data table are cut off making it slightly harder to read the column names in the table, maybe try to adjust the formatting?
  • When we select more than 4 seasons to look at the bar graph becomes hard to read and appears cluttered, maybe increasing the height or making it dynamic or relative to the number of seasons will help it format better.

Screenshot 2023-03-22 at 4 46 58 PM

  • All filters work perfectly, especially like the 'cancel' buttons next to the names.
  • The toggle button to show the dashboard details is very cool, adds interactivity!
  • Overall Great dashboard :)

@marianagyby
Copy link

Great dashboard!

  1. The app is really well thought-out and easy for an oncoming user to understand, even if they are not an expert in how the show works. The "Show Info" button is really informative for understanding the plot. The plot is really creative and makes it easy to visualize how the queens' overall performances compared to each other.

  2. Maybe the plot and table could be in separate rows, or their widths could be adjusted, so that they appear less squished on the page.

Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants