Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup markdown link syntax error #233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixup markdown link syntax error #233

wants to merge 1 commit into from

Conversation

WalterSmuts
Copy link
Contributor

No description provided.

@Narrat

This comment was marked as resolved.

Sign in to view
@WalterSmuts
Copy link
Contributor Author

Have a look at the rendered markdown here:
https://github.com/WalterSmuts/rofi-pass/tree/markdown-fix

@Narrat

This comment was marked as resolved.

Sign in to view
@WalterSmuts
Copy link
Contributor Author

https://www.markdownguide.org/basic-syntax/#reference-style-links

@Narrat
Copy link
Contributor

Narrat commented Aug 3, 2023

Ah, I see. It shouldn't be displayed down there.
Thanks for the patience.
One last thought though. All other links are using the general link syntax and now there is one occurrence of a reference style link. Isn't that somewhat confusing in the long run? (As it got me for example, although this stemmed more from the fact that I didn't know about this syntax)
Shouldn't be the style in use coherent?

@WalterSmuts
Copy link
Contributor Author

I think it's okay to use two different language features 🤷 But ultimately is a style/taste decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WalterSmuts @Narrat