Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master does not build? #696

Closed
3 tasks
stefanofornari opened this issue May 20, 2023 · 18 comments
Closed
3 tasks

master does not build? #696

stefanofornari opened this issue May 20, 2023 · 18 comments
Labels
bug Something isn't working needs triage The issue needs to be triaged, before work can commence

Comments

@stefanofornari
Copy link

stefanofornari commented May 20, 2023

Task Description

Hello,

I have just downloaded master but it does not compile. Please see below the output.

./gradlew build

> Task :test
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
<=======------> 55% EXECUTING [1m 17s]
> :test > 109 tests completed, 109 failed
> :test > Executing test org.carlspring.cloud.storage.s3fs.S3UtilsTest
^C[ste s3fs-nio] o(= ./gradlew clean build

> Task :test
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

389 tests completed, 329 failed

> Task :test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/ste/Projects/s3fs-nio/build/reports/tests/test/index.html

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/8.1.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 5m 5s
10 actionable tasks: 7 executed, 3 from cache

Tasks

The following tasks will need to be carried out:

  • Investigate the issue.
  • Provide a fix.
  • Test.

Task Relationships

This task:

Useful Links

Help

@stefanofornari stefanofornari added bug Something isn't working needs triage The issue needs to be triaged, before work can commence labels May 20, 2023
@steve-todorov
Copy link
Collaborator

Hey,

Could you please give more information about your setup?
It's building just fine in the master as you can see in gh actions (check the Build and Test step, other failures should be ignored as they will covered in #691).

Since it's showing a lot of test failures I suspect you haven't configured the amazon-test.properties as mentioned in the docs:

@carlspring
Copy link
Owner

Ciao Stefano,

Thanks for reporting this. We actually have an issue template for a reason.

What version of the JDK is this and what OS? You need to have the amazon.properties files in place.

We just merged the #693 pull request last night and you can see that it builds fine here.

Could you please provide some more details?

@stefanofornari
Copy link
Author

stefanofornari commented May 20, 2023 via email

@stefanofornari
Copy link
Author

does it require a real bucket and real access to AWS?

@carlspring
Copy link
Owner

Yes, it does.

@stefanofornari
Copy link
Author

stefanofornari commented May 20, 2023 via email

@stefanofornari
Copy link
Author

stefanofornari commented May 20, 2023 via email

@carlspring
Copy link
Owner

You can try and tell us how it goes and which S3-like service this is. We were experimenting with Minio (#103).

@carlspring
Copy link
Owner

The pom.xml was up-to-date until recently. Since yesterday we have switched out efforts to Gradle.

@steve-todorov : The Maven build scripts should be removed as well.

@carlspring
Copy link
Owner

@stefanofornari : The more questions and feedback, the better. We are busy rebooting this project, which was in hibernation for a while. If you'd like to help out, let us know! :)

@steve-todorov
Copy link
Collaborator

steve-todorov commented May 20, 2023

@carlspring FYI, the pom.xml was removed as part of #692 :)

@stefanofornari
Copy link
Author

stefanofornari commented May 20, 2023 via email

@steve-todorov
Copy link
Collaborator

steve-todorov commented May 20, 2023

Without details about your setup it is hard to guess what might be wrong.
Please fill out the following:

  1. java -version
  2. Gradle version
  3. OS (flavor and version)
  4. Are you using ./gradlew or you're using a distribution version you installed?
  5. Are you running the build in IDE or in terminal?
  6. If it's in an IDE - which one? (please don't say Eclipse... :D )

You can join our community channel here and ask your questions if you'd like:
https://chat.carlspring.org/channel/s3fs-nio-community

@stefanofornari
Copy link
Author

stefanofornari commented May 20, 2023 via email

@steve-todorov
Copy link
Collaborator

Try adding:

bash-5.1$ cat > src/test/resources/amazon-test.properties
# the "/" is mandatory at the moment.
s3fs.bucket.name=/<BUCKET_NAME>
s3fs.access.key=API_KEY
s3fs.secret.key=API_SECRET
s3fs.region=BUCKET_REGION
s3fs.protocol=https

Then do ./gradlew clean build --stacktrace

This should work - after all it's passing in GH Actions.
It's also building in docker so it's likely the property file.

@stefanofornari
Copy link
Author

stefanofornari commented May 20, 2023 via email

@stefanofornari
Copy link
Author

Just to close on the topic. I've got it to work without running ITs, which is good enough for me at least now. Thanks for your support and to put effort in this project.

@carlspring
Copy link
Owner

Thanks for letting us know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage The issue needs to be triaged, before work can commence
Projects
None yet
Development

No branches or pull requests

3 participants