-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master does not build? #696
Comments
Hey, Could you please give more information about your setup? Since it's showing a lot of test failures I suspect you haven't configured the |
Ciao Stefano, Thanks for reporting this. We actually have an issue template for a reason. What version of the JDK is this and what OS? You need to have the We just merged the #693 pull request last night and you can see that it builds fine here. Could you please provide some more details? |
Hello,
thanks for your quick response. I have definitely not configured the
environment as I was a step before trying to contributing :)
I am going to set it up and let you know (and possibly close the issue).
PS: thanks Marting as well!
Ste
…On Sat, May 20, 2023 at 5:16 PM Steve Todorov ***@***.***> wrote:
Hey,
Could you please give more information about your setup?
It's building just fine in the master as you can see in gh actions
<https://github.com/carlspring/s3fs-nio/actions/runs/5024263135/jobs/9009798761>
(check the Build and Test step, other failures should be ignored as they
will covered in #691 <#691>).
Since it's showing a lot of test failures I suspect you haven't configured
the amazon-test.properties as mentioned in the docs:
-
https://s3fs-nio.carlspring.org/contributing/developer-guide/#preparing-credentials
- Sample
<https://github.com/carlspring/s3fs-nio/blob/master/src/test/resources/amazon-test-sample.properties>
—
Reply to this email directly, view it on GitHub
<#696 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKRAWYYDM4ZO5FSWTIGGLXHDN5LANCNFSM6AAAAAAYIYX4SU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
does it require a real bucket and real access to AWS? |
Yes, it does. |
mhhh... can I also use a S3-Like service setting the entrypoint?
Ste
…On Sat, May 20, 2023 at 5:28 PM Martin Todorov ***@***.***> wrote:
Yes, it does.
—
Reply to this email directly, view it on GitHub
<#696 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKRAROGVV3XUZEOGCYET3XHDPJLANCNFSM6AAAAAAYIYX4SU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sorry to bother you guys, but I used the pom and maven all worked like a
charm... is that normal?
Ste
On Sat, May 20, 2023 at 5:29 PM Stefano Fornari ***@***.***>
wrote:
… mhhh... can I also use a S3-Like service setting the entrypoint?
Ste
On Sat, May 20, 2023 at 5:28 PM Martin Todorov ***@***.***>
wrote:
> Yes, it does.
>
> —
> Reply to this email directly, view it on GitHub
> <#696 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAKRAROGVV3XUZEOGCYET3XHDPJLANCNFSM6AAAAAAYIYX4SU>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
You can try and tell us how it goes and which S3-like service this is. We were experimenting with Minio (#103). |
The @steve-todorov : The Maven build scripts should be removed as well. |
@stefanofornari : The more questions and feedback, the better. We are busy rebooting this project, which was in hibernation for a while. If you'd like to help out, let us know! :) |
@carlspring FYI, the |
Yep, I'll be happy to help, but I really have issues with gradle ( :( ). I
know, it's my problem, but I never get a gradle project to work at the
first shot.
I recovered the pom from before it was removed. But it is strange all tests
pass without setting any properties. Maybe it does not run all tests?
Let me know also if you want me to keep going commenting on this issue or
if you prefer any other channel.
FYI I am trying the StorJ S3 gateway.
Ste
…On Sat, May 20, 2023 at 5:36 PM Steve Todorov ***@***.***> wrote:
@carlspring <https://github.com/carlspring> FYI, the pom.xml was removed
as part of #692 <#692> :)
mhhh... can I also use a S3-Like service setting the entrypoint?
If you mean using ARNs or S3 Access Points the answer is no. It is not
supported yet (check #131
<#131>)
—
Reply to this email directly, view it on GitHub
<#696 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKRAQJMC4KRCYG4IWHXFLXHDQI7ANCNFSM6AAAAAAYIYX4SU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Without details about your setup it is hard to guess what might be wrong.
You can join our community channel here and ask your questions if you'd like: |
java -version
openjdk version "1.8.0_362"
OpenJDK Runtime Environment (build
1.8.0_362-8u372-ga~us1-0ubuntu1~18.04-b09)
OpenJDK 64-Bit Server VM (build 25.362-b09, mixed mode)
uname -a
Linux minidesktop 5.4.0-148-generic #165~18.04.1-Ubuntu SMP Thu Apr 20
01:14:06 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
./gradlew --version
------------------------------------------------------------
Gradle 8.1.1
------------------------------------------------------------
Build time: 2023-04-21 12:31:26 UTC
Revision: 1cf537a851c635c364a4214885f8b9798051175b
Kotlin: 1.8.10
Groovy: 3.0.15
Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM: 1.8.0_362 (Private Build 25.362-b09)
OS: Linux 5.4.0-148-generic amd64
I am using the gradle as checked out from the project
HTH
Ste
…On Sat, May 20, 2023 at 6:06 PM Steve Todorov ***@***.***> wrote:
Without details about your setup it is hard to guess what might be wrong.
Please fill out the following:
1. java -version
2. Gradle version
3. OS (flavor and version)
4. Are you using ./gradlew or you're using a distribution version you
installed?
You can join our community channel here and ask your questions if you'd
like:
https://chat.carlspring.org/channel/s3fs-nio-community
—
Reply to this email directly, view it on GitHub
<#696 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKRASGHTBP43OOCECHTTTXHDTWZANCNFSM6AAAAAAYIYX4SU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Try adding:
Then do This should work - after all it's passing in GH Actions. |
Any way I can provide the end point too?
Ste
…On Sat, May 20, 2023 at 6:30 PM Steve Todorov ***@***.***> wrote:
Try adding:
bash-5.1$ cat > src/test/resources/amazon-test.properties
# the "/" is mandatory at the moment.s3fs.bucket.name=/<BUCKET_NAME>
s3fs.access.key=API_KEY
s3fs.secret.key=API_SECRET
s3fs.region=BUCKET_REGION
s3fs.protocol=https
Then do ./gradlew clean build --stacktrace
This should work - after all it's passing in GH Actions.
It's also building in docker so it's likely the property file.
—
Reply to this email directly, view it on GitHub
<#696 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAKRAS7QPYAVYVW4SLAY4TXHDWTHANCNFSM6AAAAAAYIYX4SU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Just to close on the topic. I've got it to work without running ITs, which is good enough for me at least now. Thanks for your support and to put effort in this project. |
Thanks for letting us know! :) |
Task Description
Hello,
I have just downloaded master but it does not compile. Please see below the output.
Tasks
The following tasks will need to be carried out:
Task Relationships
This task:
Useful Links
Help
The text was updated successfully, but these errors were encountered: