Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support S3Path.resolve(Path) for non-S3Path arguments #377

Open
2 tasks done
ennoruijters opened this issue Sep 28, 2021 · 0 comments · May be fixed by #378
Open
2 tasks done

Support S3Path.resolve(Path) for non-S3Path arguments #377

ennoruijters opened this issue Sep 28, 2021 · 0 comments · May be fixed by #378

Comments

@ennoruijters
Copy link
Contributor

ennoruijters commented Sep 28, 2021

This is a partial resubmission of Upplication/Amazon-S3-FileSystem-NIO2#104, which was made by my colleague @sbeimin.

Task Description

S3Path.resolve(Path) currently assumes that its argument is always another S3Path, and throws a ClassCastException if it is not (except for absolute paths, for which you do get a neat error message).

This is inconvenient for us, as we often store relative paths internally using the result of java.nio.file.Paths.get("example/file"). I propose to allow other Path types as arguments for relative paths.

Tasks

The following tasks will need to be carried out:

  • Allow relative non-S3Path paths as arguments to S3Path.resolve().
  • Include unit tests.

Help

@ennoruijters ennoruijters linked a pull request Sep 28, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant