-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test & Support ALKS OpenSCENARIO examples #655
Comments
Hi, great that you already created an issue for support of the OSC-ALKS-scenarios! I'm also trying to run them with CARLA now and here are my additional findings:
I will fix an issue with the start position of the ego vehicle. It starts at s=0, so in theory the rear axles are exactly on the road, but it's better if the whole vehicle is on a road on startup. So I will move it forward a few meters and adjust the scenarios. One further remark: |
Hi Andreas, thanks for your input. Let us try to get the things hunted down. Regarding the debug out: Do you know about the --debug option? This will also provide you the complete behavior tree while the scenario is executing to get an understanding which part is not working as desired. |
Could you please elaborate on the pedestrian catalog support. We have this supported and I tested your catalog and it seems to work just fine. I also just updated the loading of the OpenDRIVE map, to avoid that the map is reloaded on every call (PR #752) |
Sure, thanks for investigating. Here's the output I get when running the scenario 4.2_1, where a pedestrian from the catalog is used as blocking target: q496134@cmucl872167:~/CARLA/scenario_runner-0.9.11$ python scenario_runner.py --openscenario ../../OSC-ALKS-scenarios/Scenarios/ALKS_Scenario_4.2_1_FullyBlockingTarget_TEMPLATE.xosc --debug Another observation is that if you run scenario 4.2_4, where also a pedestrian from a catalog is used, it runs. But I didn't see the pedestrian. Here's the relevant debug output: q496134@cmucl872167:~/CARLA/scenario_runner-0.9.11$ python scenario_runner.py --openscenario ../../OSC-ALKS-scenarios/Scenarios/ALKS_Scenario_4.2_4_MultipleBlockingTargets_TEMPLATE.xosc --debug --------- Tick --------- ...
Seems like the pedestrian (TargetBlocking) is parsed from the scenario file but not added to the simulation. Only the exception from above does not occur. |
Which commit hash are you testing with? |
I'm using release 0.9.11 |
Could you try testing #713? It is not yet completed but should resolve some of the issues you might see. |
Hi, I checked out the branch and now the pedestrian scenarios run. Great! Seems these things are already fixed. |
Here's the output for scenario 4.3_1(tested with branch feat/OscControllerUpdates): q496134@cmucl872167:~/CARLA/scenario_runner$ ./scenario_runner.py --openscenario ../../OSC-ALKS-scenarios/Scenarios/ALKS_Scenario_4.3_1_FollowLeadVehicleComfortable_TEMPLATE.xosc |
A fix is integrated into the branch of #713. |
Yes, looks good. Now the scenario 4.3_1 starts. I'll mark this issue as done in the comment above. |
The issue with the ego position at the start of the road (s=0) is now fixed in the newest version of the ALKS scenarios. They were also moved to the ASAM organization GitHub account: |
One of the next topics could be the inversion of the direction of the lateral axis for positions in teleport actions according to the coordinate system definitions of OpenSCENARIO: |
I tried to test those scenarios tag/0.3.2 in Carla 0.9.13 + Scenario Runner master with merged #713 without luck:
I've also tried the current master, still no luck:
what's intended... What changes do i need to make it work? |
Hi! Great that you try to make CARLA compatible to OpenSCENARIO! |
Thank You @arauschert. A one small change for me, one giant leap for mankind ;-) |
Hi @arauschert, I have the same issue when I try to run scenario 4.3_2 as you mentioned above: "4.3_2: The speed action doesn't do anything. Don't know if it is not triggered (SimulationTimeCondition should work) or one of the attributes cannot be interpreted". Did you manage to make any progress? |
Hi @christinaSak ! Probably the acceleration/deceleration feature is contained in the branch of this PR #713 . Can you please try with this scenario_runner version? |
Thank you now it works fine, probably the AbsoluteTargetSpeed in SpeedActionTarget was not supported in the version I was using. |
Hi @arauschert. I have been running the ALKS scenarios with Carla and scenario runner but during the simulation I don't think the ALKS feature is being implemented in the scenario. For example in ALKS_Scenario_4.2_1_FullyBlockingTarget_TEMPLATE, the vehicle doesn't stop for the Pedestrian. I tried in multiple versions of Carla but that didn't help. Is there something I'm missing regarding the Controller part? Please suggest! |
Hi @rupeshreddy97 ! Yes, your observation is correct. The ALKS as system under test is not modelled in the scenario, since it is a behavioural model, which needs to be implemented by a simulation-external controller (e.g. an actual ALKS by an OEM). esmini provides an exemplary simulation-internal ALKS controller, with which you can see, how a vehicle should roughly behave in these scenarios. |
Thank you @arauschert for your input! This would really help us moving forward. |
Hi, Can you please add support for SpeedProfileAction? It really makes scenarios more simple to generate. |
HI,@arauschert. I have the same issue. In the parameter declaration section, there isn't the value "PedestrianCatalog", so I added one. But It still doesn't work for me. |
HI,@ralwing . I got the same issue as you. Did you get the code to work? What did you change for this code? |
Some additional OSC examples were published here:
https://github.com/arauschert/OSC-ALKS-scenarios
Test and find out what we need to support.
Scenarios:
The text was updated successfully, but these errors were encountered: