Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide initial contribution #2

Open
3 of 12 tasks
strieflin opened this issue Apr 4, 2023 · 0 comments
Open
3 of 12 tasks

Provide initial contribution #2

strieflin opened this issue Apr 4, 2023 · 0 comments
Assignees
@varasu @jaredweinfurtner
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@strieflin
Copy link
Member

strieflin commented Apr 4, 2023 •
edited
Loading

Before the contribution from the private fork can be merged into master a couple of things have to be done

General

  • Add license headers to source files
  • Copy over create-sbom.sh from Klyshko
  • Implement tests (>= 80% coverage expected)
  • Create workflows for testing / building
  • Remove comments from generated files
  • Setup codecov

From CSEP

  • Expose endpoints under the right URLs (see here)
  • Provide helm chart for deploying Thymus (see here).
  • Create a service provider identity that is able to manage users / access the admin interface of Kratos / Hydra (see here)
  • Ensure that the described use case work as expected (see here)
  • Create OAuth2 client with Hydra Maester (see here).

E2E testing

  • Ensure that everything works with the CS CLI
@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 4, 2023
@strieflin strieflin added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varasu varasu

@jaredweinfurtner jaredweinfurtner

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@varasu @strieflin @jaredweinfurtner