-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): stop SR announcement for hidden labels for Textinput, TimePicker #18080
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18080 +/- ##
=======================================
Coverage 82.19% 82.19%
=======================================
Files 404 404
Lines 14151 14151
Branches 4418 4468 +50
=======================================
Hits 11631 11631
Misses 2359 2359
Partials 161 161 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I believe that the point of hiding a label only visually (using our visually hidden class) is specifically so that the label is still readable by screen readers. Otherwise we could just throw a @guidari were these initial issues reported by our testing team? |
Hey @alisonjoseph I agree with you. But this was reported by Raghu, he pointed that in different components as well. I guess we can double check that with Raghu, because the label might have useful information for the screen readers, but it isn't useful visually. |
@alisonjoseph @2nikhiltom |
Thanks for checking @guidari. |
Closes #16752 #16862
SR should not announce the label when
hideLabel
is trueChangelog
New
Added
aria-hidden
attributeTesting / Reviewing
open deploy preview - turn on screen reader
for both Textinput and TimePicker components
-set the hide label Boolean to "True" and observe the SR do not announce label