-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: checkbox invalid message to match figma kit #18057
fix: checkbox invalid message to match figma kit #18057
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18057 +/- ##
==========================================
+ Coverage 82.10% 82.21% +0.11%
==========================================
Files 404 404
Lines 14107 14200 +93
Branches 4397 4513 +116
==========================================
+ Hits 11582 11674 +92
- Misses 2362 2363 +1
Partials 163 163 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Riddhi, It is looking good! Just one thing.
I think we should keep the invalid
and readonly
message inside the fieldset
. If you test with VO in the current Storybook, you’ll notice that they are grouped together, which helps the screen reader user understand that the message is part of the same group label.
We can also confirm that with Raghu if needed.
Oh I see what you are saying !! |
682cbfa
to
ef9144c
Compare
Hey @guidari Look at this found an alternative way to fix that bug . Lemme know what do you think about it ? We can modify the test case if its a good approach to look from accessibility pov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does technically fix the bug, however I think it would be preferable if we just update the styles vs. changing the underlying html structure. I believe you should be able to add a inline-size (width) of 100% to the invalid or warn text when its horizontal and it will display correctly below the checkboxes.
3772ad2
Hey there! v11.71.0 was just released that references this issue/PR. |
Closes #18033
CheckboxGroup component renders the invalidText at the different position from the figma library.
With orientation="horizontal", invalidText shows at the right of the Checkboxs, and I expected it to be shown at the bottom.
Changelog
Changed
Testing / Reviewing
Go to checkbox and check if invalid message is rendered correctly at bottom