-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase coverage for ControlledPasswordInput #17872
base: main
Are you sure you want to change the base?
test: increase coverage for ControlledPasswordInput #17872
Conversation
All contributors have signed the DCO. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
b27e3f0
to
c608612
Compare
ce67c1a
to
6c3396c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17872 +/- ##
==========================================
+ Coverage 82.10% 82.42% +0.31%
==========================================
Files 404 404
Lines 14107 14107
Branches 4397 4430 +33
==========================================
+ Hits 11582 11627 +45
+ Misses 2362 2317 -45
Partials 163 163 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
86105fe
to
0f63d5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @emil-ep! There is a __tests__
folder within TextInput
, can this test file be placed there?
0f63d5e
to
db83e34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Increases test coverage for ControlledPasswordInput #17476