Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase coverage for ControlledPasswordInput #17872

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

emil-ep
Copy link

@emil-ep emil-ep commented Oct 24, 2024

Increases test coverage for ControlledPasswordInput #17476

@emil-ep emil-ep requested a review from a team as a code owner October 24, 2024 14:24
Copy link
Contributor

github-actions bot commented Oct 24, 2024

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 991ceda
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67457eacd288480008306f46
😎 Deploy Preview https://deploy-preview-17872--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emil-ep
Copy link
Author

emil-ep commented Oct 24, 2024

I have read the DCO document and I hereby sign the DCO.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 991ceda
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67457eac0854d40008175c3b
😎 Deploy Preview https://deploy-preview-17872--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 24, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 991ceda
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67457eac1afb810008c3c09f
😎 Deploy Preview https://deploy-preview-17872--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emil-ep emil-ep force-pushed the tests-controlledPasswordInput branch from b27e3f0 to c608612 Compare October 24, 2024 14:37
@emil-ep emil-ep force-pushed the tests-controlledPasswordInput branch from ce67c1a to 6c3396c Compare November 5, 2024 07:29
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (126c4ed) to head (db83e34).
Report is 45 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17872      +/-   ##
==========================================
+ Coverage   82.10%   82.42%   +0.31%     
==========================================
  Files         404      404              
  Lines       14107    14107              
  Branches     4397     4430      +33     
==========================================
+ Hits        11582    11627      +45     
+ Misses       2362     2317      -45     
  Partials      163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@annawen1 annawen1 changed the title [Unit-test]: ControlledPasswordInput test: increase coverage for ControlledPasswordInput Nov 8, 2024
@emil-ep emil-ep force-pushed the tests-controlledPasswordInput branch from 86105fe to 0f63d5e Compare November 9, 2024 04:32
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emil-ep! There is a __tests__ folder within TextInput, can this test file be placed there?

@emil-ep emil-ep force-pushed the tests-controlledPasswordInput branch from 0f63d5e to db83e34 Compare November 13, 2024 09:10
@emil-ep
Copy link
Author

emil-ep commented Nov 13, 2024

Thanks @emil-ep! There is a __tests__ folder within TextInput, can this test file be placed there?

@annawen1 Moved the test file to __tests__ directory

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants